[WAGON-242] FtpWagon class needs to handle possible null returned from ftpFiles[0].getTimestamp()

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.0-beta-4
• Fix Version/s: 1.0-beta-5
• Component/s: wagon-ftp
• Environment: IBM z/OS Unix System Services
• Assignee: Brett Porter
• Reporter: D.R.
• Created: 24/Sep/08 11:54
• Updated: 18/Feb/09 23:23
• Resolved: 18/Feb/09 23:23

Description

The following line can return a null value, causing a null pointer exception in the code.

FtpWagon.fillInputData()
...
//@todo check how it works! javadoc of common login says:
// Returns the file timestamp. This usually the last modification time.
//
long lastModified = ftpFiles[0].getTimestamp().getTimeInMillis();
...

org.apache.commons.net.ftp.parser.UnixFTPEntryParser.parseFTPEntry()
...
try
{
file.setTimestamp(super.parseTimestamp(datestr));
}
catch (ParseException e)
{
return null; // this is a parsing failure too.
}
...