Uploaded image for project: 'Commons VFS'
  1. Commons VFS
  2. VFS-99

Changes in interface RandomAccessContent.

    XMLWordPrintableJSON

    Details

    • Type: Wish
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      I think the interface RandomAccessContent should not extend DataOutput nor DataInput;
      Instead, it could declare the following new methods:

      1) int read(byte b[], int off, int len) throws IOException;
      2) void write(byte b[], int off, int len) throws IOException;

      3) int pread(long pos, byte b[], int off, int len) throws IOException;
      4) void pwrite(long pos, byte b[], int off, int len) throws IOException;

      Instead of changing this interface, a new one could be created (RandomAccessStream, maybe).

      Benefits:
      Currently, if a class implements this interface, it has to implement method "skipBytes", which is redundant since it already implements method "seek".

      It also has to implement 14 methods related to reading, which is also redundant since they can be expressed in terms of specific calls to more primitive methods such as those proposed above.

      In other words, I don't think different classes implementing RandomAccessContent (or RandomAccessStream) should all implement methods "readShort", "readInt"", "readLong", etc, since all implementations of them will be the same, if they are expressed in terms of calls to read(byte b[], int off, int len).

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              elifarley@yahoo.com Elifarley Callado Coelho
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: