[VFS-724] FileContent#getByteArray() throws IllegalArgumentException: Buffer size <= 0 when file size is 0

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4
• Fix Version/s: 2.4.1
• Assignee: Unassigned
• Reporter: William Rey
• Created: 09/Aug/19 20:49
• Updated: 10/Aug/19 13:29
• Resolved: 10/Aug/19 13:29

Description

The current code only checks for a size bigger than 2MB but ignores when the returned size is 0 or negative. sizeL will be typically equals to zero if the request is made to a WebServer and the response generated live (like PHP). Then the getInputStream(size) will fail in this case when the size is really used by the implementation.

    default byte[] getByteArray() throws IOException {
        final long sizeL = getSize();
        if (sizeL > Integer.MAX_VALUE) {
            throw new IllegalStateException(String.format("File content is too large for a byte array: %,d", sizeL));
        }

Issue Links

• links to: GitHub Pull Request #68