[VFS-674] Cannot close an FTP input stream without an exception

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.2
• Fix Version/s: 2.3
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Boris Petrov
• Created: 10/Sep/18 09:44
• Updated: 20/Nov/18 15:04
• Resolved: 20/Nov/18 15:04

Description

The FTP server is FileZilla.

1. Get a stream instance from an FtpFileObject via the `getInputStream` method.
2. Read some bytes from the stream.
3. Close the stream via `stream.close()`.
4. If the stream has not been completely read, the FTP server sends a `426 Connection closed; transfer aborted` response code.
5. `FtpFileObject::onClose` is called.
6. Eventually `FTPReply::isPositiveCompletion` is called.
7. Since the response code is outside the [200; 300) range it is considered an error.
8. A `FileSystemException` is thrown.

The overall result is that when closing a stream that is not completely read an exception is thrown. Which is obviously wrong.

A similar things happens with this piece of code:

try (FileContent content = ftpFileObject.getContent()) {
    // ......
}

Is there an easy way we can patch this in VFS as this is a showstopper for us?