[VFS-617] SFTP isReadable fails if unable to determine group identity

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.5.0

Environment

Windows 7 Java 7. Failure occured connecting via SFTP to a Synology box running DSM 6.

• Assignee: Unassigned
• Reporter: Tim Nickels
• Created: 30/Jun/16 11:07
• Updated: 20/Nov/22 13:37
• Resolved: 23/Dec/19 18:19

Description

The doIsReadable method of SftpFileObject throws an exception if the system cannot identify group/owner permissions.......

Exception in thread "main" org.apache.commons.vfs2.FileSystemException: Could not determine if file "sftp://myURI" is readable.
at org.apache.commons.vfs2.provider.AbstractFileObject.isReadable(AbstractFileObject.java:1761)
at com.avenca.vfs.VFSUtils.main(VFSUtils.java:41)
Caused by: com.jcraft.jsch.JSchException: Could not get the groups id of the current user (error code: 1)
at org.apache.commons.vfs2.provider.sftp.SftpFileSystem.getGroupsIds(SftpFileSystem.java:263)
at org.apache.commons.vfs2.provider.sftp.SftpFileObject.getPermissions(SftpFileObject.java:317)
at org.apache.commons.vfs2.provider.sftp.SftpFileObject.doIsReadable(SftpFileObject.java:335)
at org.apache.commons.vfs2.provider.AbstractFileObject.isReadable(AbstractFileObject.java:1757)

The problem is the method is using

return getPermissions(true).isReadable()

The folder is readable without these permissions, and so should be set to

return getPermissions(false).isReadable()

Which correctly allows the system to identify a readable folder without adding unnecessary restrictions.