Uploaded image for project: 'Commons VFS'
  1. Commons VFS
  2. VFS-492

Support FEAT and MLSx commands for FTP performance improvements.

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Environment:

      Development:
      Windows 7 Pro.
      Java 1.7.0_25
      Eclipse SDK 4.2.2

      Target:
      All

      Description

      While using VFS to synchronize/push files between a local file system and an FTP server I noticed severe performance issues whenever the FTP directory had a large number of files. Each refresh of an FtpFileObject asks for a list of the files in the parent directory, and then attempts to pick out the information for a single file. Performance will degrade quickly as the number of files to be listed increases.

      I'd suggest using MLST and MLSD as an alternative to LIST, where possible. MLST can retrieve the necessary file information without listing a whole directory. Both commands also provide unambiguous time-stamps, which was also a problem that I ran into while trying to compare modification times between the local and FTP file systems.

      Attached is a patch that probably does the job. In cases where MLSx features are not supported, the original LIST command will be used. Tests are included. Since I'm new to VFS I'm not sure if this covers all cases, so be warned.

        Attachments

        1. ftp-mlsx.patch
          19 kB
          Scott Embler
        2. VFS-492-v2.patch
          26 kB
          Simon Legner

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sembler Scott Embler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified