Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
1.0, 2.0
-
None
-
Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_24\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_24, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_24\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
Description
As a call site, I want to say fileObject.isFile(), not FileType.FILE.equals(fileObject.getType()) or fileObject.getType() == FileType.FILE
It turns out this equals()/== pattern is repeated internally quit a bit. Refactor that to use the new API.
Same idea for FileName isFile (but there are fewer call sites to refactor.)