[VFS-286] SFTP: getChildren() does not restore working dir if exception is thrown

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Nightly Builds
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Kirill Safonov
• Created: 18/Oct/09 17:15
• Updated: 07/Nov/09 17:51
• Resolved: 03/Nov/09 19:00

Description

SftpFileObject.doListChildrenResolved() changes the working dir before doing ChannelSftp.ls() call. If ls() throws an exception (in my case it's SftpException "No such file" when trying to list the contents of "/dev/cdrom"), the execution is blown out the method and channel.cd(workingDirectory) is not performed. All the subsequent operations that rely on the current dir will fail trying to cd() into unexisting directory.

The fix will be to move the channel.cd(workingDirectory); part into the finally {} block below