[VFS-285] AbstractFileObject.getChildren(): internal structures will be left inconsistent if the excepion is thrown

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Nightly Builds
• Fix Version/s: 2.1
• Assignee: Unassigned
• Reporter: Kirill Safonov
• Created: 18/Oct/09 15:26
• Updated: 19/May/16 18:26
• Resolved: 16/Jan/13 09:53

Description

AbstractFileObject.getChildren() creates children array and then fills it by resolving child names via FileSystemManager.resolveName(). If the latter method throws an exception (in my case it's "Invalid descendent file name "pci-0000:00:07.1-scsi-0:0:0:0""), children array is left as is with some of the entries = null, that inevitably results in NPE on the next getChildren() call:
at org.apache.commons.vfs.provider.AbstractFileSystem.resolveFile(AbstractFileSystem.java:319)
at org.apache.commons.vfs.provider.AbstractFileSystem.resolveFile(AbstractFileSystem.java:314)
at org.apache.commons.vfs.provider.AbstractFileObject.resolveFile(AbstractFileObject.java:723)
at org.apache.commons.vfs.provider.AbstractFileObject.resolveFiles(AbstractFileObject.java:715)
at org.apache.commons.vfs.provider.AbstractFileObject.getChildren(AbstractFileObject.java:618)
at org.apache.commons.vfs.provider.ftp.FtpFileObject.getChildren(FtpFileObject.java:412)

since AbstractFileObject.getChildren() only checks that children instance is not null