[VFS-236] SmbFileObject throws NPE when used without authentication

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Nightly Builds
• Fix Version/s: 2.1
• Assignee: Bernd Eckenfels
• Reporter: Matt Casters
• Created: 05/Feb/09 23:06
• Updated: 19/May/16 18:25
• Resolved: 12/Apr/15 17:46

Description

If you have a shared folder without authentication, SmbFileObject throws an NPE in method createSmbFile().

Here is what I changed to get it to run:

private SmbFile createSmbFile(FileName fileName) throws MalformedURLException, SmbException, FileSystemException
{
SmbFileName smbFileName = (SmbFileName) fileName;

String path = smbFileName.getUriWithoutAuth();

UserAuthenticationData authData = null;
SmbFile file;
NtlmPasswordAuthentication auth;
try
{
authData = UserAuthenticatorUtils.authenticate(getFileSystem().getFileSystemOptions(), SmbFileProvider.AUTHENTICATOR_TYPES);
if (authData!=null)

{ auth = new NtlmPasswordAuthentication( UserAuthenticatorUtils.toString( UserAuthenticatorUtils.getData( authData, UserAuthenticationData.DOMAIN, UserAuthenticatorUtils.toChar(smbFileName.getDomain()))), UserAuthenticatorUtils.toString( UserAuthenticatorUtils.getData( authData, UserAuthenticationData.USERNAME, UserAuthenticatorUtils.toChar(smbFileName.getUserName()))), UserAuthenticatorUtils.toString( UserAuthenticatorUtils.getData( authData, UserAuthenticationData.PASSWORD, UserAuthenticatorUtils.toChar(smbFileName.getPassword())))); file = new SmbFile(path, auth); }

else

{ auth=null; file = new SmbFile(path); }

}
finally

{ UserAuthenticatorUtils.cleanup(authData); }

if (file.isDirectory() && !file.toString().endsWith("/"))
{
if (auth!=null)

{ file = new SmbFile(path + "/", auth); }

else

{ file = new SmbFile(path + "/"); }

}

return file;
}