Uploaded image for project: 'Velocity Tools'
  1. Velocity Tools
  2. VELTOOLS-89

LinkTool's addQueryData method should automatically add an 'ignore' so addAllParameters will ignore manually-added query data

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 1.x, 1.4, 2.x, 3.0
    • VelocityView
    • None

    Description

      Currently, the LinkTool requires that, for each parameter you intend to override from the current request (when using addAllParameters), you do something like this:

      $link.addIgnore("foo").addQueryData("foo", "bar").addAllParameters()

      It is almost always the case that the "foo" parameter should be ignored from the current request because it's value is being explicitly set by the addQueryData call.

      This should be the default behavior, with the current behavior being configurable via the toolbox setup.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            chris@christopherschultz.net Christopher Schultz
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment