[VELTOOLS-87] Infinite recursion of the RenderTool.recurse(Context, String) method

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.2, 1.3, 1.x, 1.4, 2.x
• Fix Version/s: 1.x, 1.4, 2.x, 3.0
• Component/s: GenericTools
• Assignee: Unassigned
• Reporter: Andrea Bernardo Ciddio
• Created: 05/Oct/07 00:26
• Updated: 07/Jan/18 19:38
• Resolved: 26/Oct/07 23:12

Description

The recurse method never returns when the vtl template contains a loop (should have been fixed in rev 321227):

RenderTool tool = new RenderTool();
VelocityContext ctx = new VelocityContext();
String vtl = "#set($foo = 'I am [$foo]') $foo";
System.out.println(tool.recurse(ctx, vtl));

[StackOverflow]

the issue is caused by a misplaced '++' operator in the internalRecurse method:

protected String internalRecurse(Context ctx, String vtl, int count) throws Exception
{
String result = eval(ctx, vtl);
if (result == null || result.equals(vtl))

{ return result; }

else
{
// if we haven't reached our parse depth...
if (count < parseDepth)

{ // continue recursing return internalRecurse(ctx, result, count++); // <==== BUG: should be '++count' }

else

{ // abort and return what we have so far //FIXME: notify the developer or user somehow?? return result; }

}
}

The counter is updated after the recursive call returns, which never happens