Uploaded image for project: 'Velocity Tools'
  1. Velocity Tools
  2. VELTOOLS-168

LinkTool doesn't handle appending params properly

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: None
    • Labels:
      None

      Description

      When using the LinkTool (generic) to append parameters, the call to appendParam(String, key, String value) uses instanceof to see if the parameter to append to is a List object, but the query is populated with Array objects from request.getParameterMap().

      Just need to change generic.LinkTool.java:547 from 'if (cur instanceof List)' to 'if (cur instanceof List || cur instanceof Array)'.

      Call to addToList already handles List vs Arrays, so I don't think any other changes need to be put in place.

        Attachments

          Activity

            People

            • Assignee:
              cbrisson Claude Brisson
              Reporter:
              hudson_s Hudson S
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: