[VELTOOLS-149] LinkTool.addRequestParams methods are difficult to use from VTL due to their String[] parameter type

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.0.x, 3.0
• Environment: Velocity 1.7, Velocity-Tools 2.0
• Assignee: Unassigned
• Reporter: Christopher Schultz
• Created: 27/Jul/11 21:32
• Updated: 07/Jan/18 19:35
• Resolved: 27/Jul/11 22:10

Description

If I call addRequestParams() with no argument, things work as expect. On the other hand, this does not work:

#set($ignoreList = ['foo'])
$link.relative('/bar').addRequestParamsExcept($ignoreList)

I get an invalid reference log message and the above "$link..." text is rendered as written instead of evaluating successfully.

The problem is that the ignoreList is a List and it needs to be String[]. Velocity will auto-convert Lists into Object[] if appropriate, but the resulting object type is Object[] and not String[].

There does not appear to be a way to create a String[] from a Velocity template, so using addRequestParams and the other, similar methods will be very difficult to use with an argument.

LinkTool.addRequestParams and friends should be modified to accept Object[] arguments.