[VELTOOLS-130] ViewToolManager constructor ViewToolManager(servletContext) throws NPE always

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.0.x, 2.x, 3.0
• Component/s: VelocityView
• Environment: Ubuntu 10.10, JDK 1.6.21, Tomcat 6.0.20
• Assignee: Unassigned
• Reporter: Robert Brandner
• Created: 15/Oct/10 19:31
• Updated: 07/Jan/18 19:35
• Resolved: 15/Oct/10 20:46

Description

Invoking the constructor ViewToolManager(servletContext) always fails with an NPE. The reason for this is, that it invokes super(true, true) before setting the member variable servletContext with the provided servletContext.

The parent class' constructor invokes autoConfigure(true) which invokes ServletUtils.getConfiguration(servletPath). At this moment servletPath can only be null as it is not set yet. And that finally leads to a NPE in the first line of the getConfiguration method:

Object obj = application.getAttribute(CONFIGURATION_KEY);

Workaround: Use a constructor without autoconfiguration and invoke autoConfigure(true) afterwards.

ViewToolManager vm = new ViewToolmanager(servletContext, false, false);
vm.autoConfigure(true);