Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Component/s: Build
    • Labels:
      None
    • Environment:
      Maven

      Description

      After VELTOOLS-121 fix, some tests fail under Maven. Here is the list

      Tests in error:
      methodConfigure_ValueParser(org.apache.velocity.tools.generic.XmlToolTests)
      methodToString(org.apache.velocity.tools.generic.XmlToolTests)
      testStringFileEquals(org.apache.velocity.tools.generic.XmlToolTests)
      testBrowserSnifferTool(org.apache.velocity.tools.test.blackbox.ViewToolsTests)
      testContextTool(org.apache.velocity.tools.test.blackbox.ViewToolsTests)
      testLinkTool(org.apache.velocity.tools.test.blackbox.ViewToolsTests)
      testParameterParserTool(org.apache.velocity.tools.test.blackbox.ViewToolsTests)
      testXmlConfig(org.apache.velocity.tools.test.whitebox.ConfigTests)
      testOldConfig(org.apache.velocity.tools.test.whitebox.ConfigTests)
      testPropsConfig(org.apache.velocity.tools.test.whitebox.ConfigTests)
      testPropsPlusXmlConfig(org.apache.velocity.tools.test.whitebox.ConfigTests)
      org.apache.velocity.tools.test.whitebox.GenericToolsTests

      Tests run: 217, Failures: 0, Errors: 12, Skipped: 0

        Activity

        Hide
        brenmcguire Antonio Petrelli added a comment -

        This patch modifies the tests to work under Maven 2 and Ant.
        Now, resources once loaded directly from a File, are now loaded as resources and copied into temporary files, then accessed as files. This way most of the tests were not rewritten, with the exception of resource loading and copying.
        Added Commons-IO as a test dependency to ease copying of resources.
        The Ant configuration needed some more tricks to make the test succeed.

        The ViewToolTests are excluded from Maven tests since it is an integration test, and it needs more configuration to run a web server and then launch the test.

        Show
        brenmcguire Antonio Petrelli added a comment - This patch modifies the tests to work under Maven 2 and Ant. Now, resources once loaded directly from a File, are now loaded as resources and copied into temporary files, then accessed as files. This way most of the tests were not rewritten, with the exception of resource loading and copying. Added Commons-IO as a test dependency to ease copying of resources. The Ant configuration needed some more tricks to make the test succeed. The ViewToolTests are excluded from Maven tests since it is an integration test, and it needs more configuration to run a web server and then launch the test.
        Hide
        brenmcguire Antonio Petrelli added a comment -

        The tests have been fixed a lot of time ago.

        Show
        brenmcguire Antonio Petrelli added a comment - The tests have been fixed a lot of time ago.

          People

          • Assignee:
            brenmcguire Antonio Petrelli
            Reporter:
            brenmcguire Antonio Petrelli
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development