[VELOCITY-962] Unclosed #[[ is no longer an error

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3
• Fix Version/s: 2.4
• Component/s: Engine
• Assignee: Unassigned
• Reporter: Éamonn McManus
• Created: 03/Jan/23 19:32
• Updated: 24/Aug/24 11:06
• Resolved: 24/Aug/24 11:06

Description

With Velocity 1.7, if you had #[[ without ]]# then you would get an exception like this:

org.apache.velocity.runtime.parser.ParseException: Lexical error: org.apache.velocity.runtime.parser.TokenMgrError: Lexical error at line 4, column 5.  Encountered: <EOF> after : ""
        at org.apache.velocity.runtime.parser.Parser.parse(Parser.java:136)
        at org.apache.velocity.runtime.RuntimeInstance.parse(RuntimeInstance.java:1226)
        at org.apache.velocity.runtime.RuntimeInstance.parse(RuntimeInstance.java:1181)

However, with 2.3 this is just silently accepted. I think it would be better to continue to throw an exception, and better still if the exception message indicated where the #[[ started.