Uploaded image for project: 'Velocity'
  1. Velocity
  2. VELOCITY-962

Unclosed #[[ is no longer an error

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3
    • 2.4
    • Engine
    • None

    Description

      With Velocity 1.7, if you had #[[ without ]]# then you would get an exception like this:

      org.apache.velocity.runtime.parser.ParseException: Lexical error: org.apache.velocity.runtime.parser.TokenMgrError: Lexical error at line 4, column 5.  Encountered: <EOF> after : ""
              at org.apache.velocity.runtime.parser.Parser.parse(Parser.java:136)
              at org.apache.velocity.runtime.RuntimeInstance.parse(RuntimeInstance.java:1226)
              at org.apache.velocity.runtime.RuntimeInstance.parse(RuntimeInstance.java:1181)

      However, with 2.3 this is just silently accepted. I think it would be better to continue to throw an exception, and better still if the exception message indicated where the #[[ started.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            eamonnmcmanus Éamonn McManus
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment