[VELOCITY-908] Initialization failure on Windows with Turkish locale

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.1
• Component/s: Engine
• Environment: Windows with Turkish locale
• Assignee: Michael Osipov
• Reporter: Pierre-Benoît Côté
• Created: 25/Jan/19 20:18
• Updated: 27/Mar/19 21:44
• Resolved: 16/Feb/19 22:42

Description

velocity-engine-core/2.0 fails to initialize on a Windows machine with Turkish locale.

 

Invocation of init method failed; nested exception is java.lang.IllegalArgumentException: No enum constant org.apache.velocity.runtime.RuntimeConstants.SpaceGobbling.LİNES

 

The code is catching `NoSuchElementException` instead of the `IllegalArgumentException` that is being thrown by Enum.valueOf

 

https://github.com/apache/velocity-engine/blob/42e56bf3328e6b8f496503dc198d876def70fb78/velocity-engine-core/src/main/java/org/apache/velocity/runtime/RuntimeInstance.java#L356

 

https://docs.oracle.com/javase/9/docs/api/java/lang/Enum.html#valueOf(java.lang.Class,%20java.lang.String)

Issue Links

• is related to: SOLR-13351 Workaround for VELOCITY-908