Uploaded image for project: 'Velocity'
  1. Velocity
  2. VELOCITY-892

Method arguments conversions should be based on Type instead of Class

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Component/s: Engine
    • Labels:
      None

      Description

      I was happy to see that method arguments conversion has been added to 2.0 so that I can remove the uberspector we have on XWiki side but unfortunately ConversionHandler is limited to classes which is way too restrictive for us (for example if the parameter type is List<String> it won't do the same thing than if the type is List<Integer>).

      Our uberspector can be found on https://github.com/xwiki/xwiki-commons/blob/master/xwiki-commons-core/xwiki-commons-velocity/src/main/java/org/xwiki/velocity/introspection/MethodArgumentsUberspector.java to see what we do exactly.

        Attachments

          Activity

            People

            • Assignee:
              claude Claude Brisson
              Reporter:
              tmortagne Thomas Mortagne
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: