[VELOCITY-889] Regression for closing round parenthesis in macro calls compared to v1.7

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.1
• Component/s: Engine
• Environment: Windows 7 ; Java SE 1.8.0-152
• Assignee: Claude Brisson
• Reporter: Oliver Moehrke
• Created: 12/Jan/18 13:41
• Updated: 02/Jan/19 16:18
• Resolved: 08/Oct/18 22:44

Description

The v2.0 engine throws a ParseErrorException for macro calls like:

#macro(printCertificateToggleRow $keyName, $summary, $certificateDetails, $cssSummary)
  #printToggleAccordionDataCSS(
    "#printLabelValue($keyName, $summary)",
    "#printCertificateDetails($certificateDetails)",
    "",
    $cssSummary,
    "",
    ""
  )
#end

It seems, that the closing round parenthesis has a problem with the line break (0x0D0A). It works, if the closing parenthesis stands right behind the last parameter.

Exception (partly):

Caused by: org.apache.velocity.exception.ParseErrorException: Encountered ")" at html/inspectionsheet_html_macros.vm[line 69, column 5]
Was expecting one of:
    "," ...
    "##" ...
    <WHITESPACE> ...
    <NEWLINE> ...

Issue Links

• is duplicated by: VELOCITY-893 Calling macro with closing brace on newline throws ParseErrorException