Uploaded image for project: 'Velocity'
  1. Velocity
  2. VELOCITY-760

DataSourceResourceLoader doesn't close PreparedStatements

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.2
    • Fix Version/s: 1.7, 2.0
    • Component/s: Engine
    • Labels:
      None

      Description

      DataSourceResourceLoader.java contains this method:

      private ResultSet readData(final Connection conn,
      final String columnNames,
      final String templateName) throws SQLException

      { PreparedStatement ps = conn.prepareStatement("SELECT " + columnNames + " FROM "+ tableName + " WHERE " + keyColumn + " = ?"); ps.setString(1, templateName); return ps.executeQuery(); }

      PreparedStatements created in this method never get closed, only the resultset returned may eventually be closed later which isn't sufficient for releasing all bound resources. In my project this statement leak lead to the oracle running out of open cursors (the infamous ORA-01000 error).

        Attachments

        1. velocity-760.patch
          3 kB
          Jarkko Viinamäki

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              schrom Jerome Waibel
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: