Uploaded image for project: 'Velocity'
  1. Velocity
  2. VELOCITY-566

EmptyStackException when rendering macros simultaneously

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6
    • Component/s: Engine
    • Labels:
      None

      Description

      When two threads are running VelocimacroFactory.startRenderingMacro() simultaneously (same template), both check that templateMap is empty, then both create a new stack, then the second thread put it in templateMap, replacing the one added by the first thread.

      At this time we got a stack which size == 1 instead of 2.

      Then both threads endProcessingMacros(), both get stack from templateMap and check that its size is > 0, first one empty stack then second pop() macro and gets an EmptyStackException.

      behavior was introduced by improvement VELOCITY-297.

      patch is joined, synchronize(templateMap) in VelocimacroFactory.startRenderingMacro().

        Activity

        Hide
        wglass Will Glass-Husain added a comment -

        Hi Etienne –

        Thanks for contributing! (and nice catch). Does "ant test" work?

        Also, just a quick note. Remember when submitting patches in the future to follow the code style guidelines (on our Wiki). We tend to be irritatingly picky about braces on their own line. (Makes the code easier to read). I'll fix them this time.

        Show
        wglass Will Glass-Husain added a comment - Hi Etienne – Thanks for contributing! (and nice catch). Does "ant test" work? Also, just a quick note. Remember when submitting patches in the future to follow the code style guidelines (on our Wiki). We tend to be irritatingly picky about braces on their own line. (Makes the code easier to read). I'll fix them this time.
        Hide
        emassip Etienne Massip added a comment -

        I forgot that brace thing, sorry. Yes, "ant test" does work.

        Thanks !

        Show
        emassip Etienne Massip added a comment - I forgot that brace thing, sorry. Yes, "ant test" does work. Thanks !
        Hide
        wglass Will Glass-Husain added a comment -

        patch committed - thanks!

        Show
        wglass Will Glass-Husain added a comment - patch committed - thanks!

          People

          • Assignee:
            Unassigned
            Reporter:
            emassip Etienne Massip
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development