Velocity
  1. Velocity
  2. VELOCITY-493

RuntimeInstance.getProperty() should check overridingProperties when not yet initialized

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5 beta1
    • Fix Version/s: 1.5
    • Component/s: Engine
    • Labels:
      None
    • Environment:
      all

      Description

      For consistency, RuntimeInstance.getProperty() should return the values previously set with setProperty() event when it hasn't already been initialized.

      runtimeInstance.setProperty("foo","bar");
      System.out.println(runtimeInstance.getProperty("foo")); // output "null"
      runtimeInstance.init();
      System.out.println(runtimeInstance.getProperty("foo")); // output "bar"

      1. runtimeinstance.patch
        0.8 kB
        Claude Brisson

        Activity

        Hide
        Claude Brisson added a comment -

        This patch solves this issue.

        Note: the issue was initially raised by Mike Kienenberger while trying to integrate Velosurf in VPP.

        Show
        Claude Brisson added a comment - This patch solves this issue. Note: the issue was initially raised by Mike Kienenberger while trying to integrate Velosurf in VPP.
        Hide
        Will Glass-Husain added a comment -

        Patch applied. Thanks Claude for the patch and Mike for raising the issue!

        (minor note: remember our code style re: braces when submitting patches, please).

        Show
        Will Glass-Husain added a comment - Patch applied. Thanks Claude for the patch and Mike for raising the issue! (minor note: remember our code style re: braces when submitting patches, please).
        Hide
        Henning Schmiedehausen added a comment -

        Please don't close issues, resolve them.

        Show
        Henning Schmiedehausen added a comment - Please don't close issues, resolve them.
        Hide
        Henning Schmiedehausen added a comment -

        Patch applied

        Show
        Henning Schmiedehausen added a comment - Patch applied
        Hide
        Henning Schmiedehausen added a comment -

        Close all resolved issues for Engine 1.5 release.

        Show
        Henning Schmiedehausen added a comment - Close all resolved issues for Engine 1.5 release.

          People

          • Assignee:
            Henning Schmiedehausen
            Reporter:
            Claude Brisson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development