Uploaded image for project: 'Velocity'
  1. Velocity
  2. VELOCITY-467

Throw more exceptions and log less errors

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5 beta1
    • Fix Version/s: 1.6
    • Component/s: Engine
    • Labels:
      None

      Description

      Now that Velocity application exceptions are based on RuntimeException, we have more opportunity to use exceptions to signal application level problems. I'm particularly concerned about initialization problems that are logged and may be missed. We need to review all logged error messages and see if it would be more appropriate to throw an exception instead. Some of these places we may need to leave as is for backwards compatibility reasons. (e.g. macro in the global macro library doesn't parse properly).

      Llewellyn Falco made a good case for this on the dev list recently:

      http://www.mail-archive.com/velocity-dev@jakarta.apache.org/msg15067.html

      #####
      I still would like to put in my vote that sending error's to the log is an incredibly BAD idea.

      If something is not working, it should be LOUDLY shown as an exception.
      If it is working I don't really need a log.

      The (velocity) log should be there for velocity developers (those programming the actual velocity code) not users.

      I don't ever care to see tomcat's log, I care to see the things I log while in tomcat.

      Most of all, many many many people do not check the log at all, let alone frequently.
      ####

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              wglass Will Glass-Husain
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: