Uploaded image for project: 'Velocity'
  1. Velocity
  2. VELOCITY-454

clean up escaping to always escape \$ and \#

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.4, 1.5
    • 2.0
    • Engine
    • None

    Description

      I want to use Velocity to generate a template for UJAC, which uses a very similiar templating language to Velocity. Therefore escaping is a primary concern.

      I am surprised that there seems to be no way to just escape "$" and "#" in general.

      Suppose we have the line \$name

      If name is in the context, this will evaluate to $name, otherwise it will evaluate to \$name

      The real problem starts if there is something to escaped like

      ${something == 3} (this is something that might occur in a UJAC template)

      This gives an error in both cases: ${something == 3} and \${something == 3} both give an error ("} expected" or something like that).

      My guess is that Velocity get's confused when trying to evaluate "something == 3" to see if it is something that is known and should be escaped or something that is unknown and should not be escaped.

      In my opinion the proper behaviour for escaping characters would be to ALWAYS escape, independent of the context.

      Even if the current way of escaping would work in all cases, there would be a major problem with it. I can't give the velocity template to the Designer, because only the developer knows all the variables that exist in the context. So the designer is unable to properly escape all the variables. I think it would be important to have a way to simply escape everything.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            bjoern_sec Bjoern Guenzel
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment