[VELOCITY-453] [PATCH] Fix IntrospectionCacheData caching - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.5
Fix Version/s: 1.5
Component/s: Engine
Labels:
None

Description

The old code used Class[].hashCode() in MethodCacheKey.hashCode() implementation.
hashCode() is not overriden for arrays so it returns different value for each array instance.

The attached is the correct implementation and a test case to prove the caching actually works.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

ASF.LICENSE.NOT.GRANTED--ASTMethod_IntrospectionCacheData_cache
31/Aug/06 05:53
3 kB
Alexey Panchenko
ASF.LICENSE.NOT.GRANTED--IntrospectionCacheDataTest.java
31/Aug/06 05:53
2 kB
Alexey Panchenko
ASTMethod_IntrospectionCacheData_cache-v2.patch
31/Aug/06 08:42
3 kB
Alexey Panchenko
ASTMethod_IntrospectionCacheData_cache-v2-retry.patch
31/Aug/06 13:46
3 kB
Alexey Panchenko
ASTMethod.java.patch2006-09-28
28/Sep/06 07:07
2 kB
Alexey Panchenko
IntrospectionCacheDataTest-no-copyright.java
07/Sep/06 08:10
1 kB
Alexey Panchenko
IntrospectionCacheDataTest-no-copyright.java
07/Sep/06 08:09
1 kB
Alexey Panchenko
IntrospectionCacheDataTest-v4.java
07/Sep/06 08:12
1 kB
Alexey Panchenko

Activity

People

Assignee:: William Glass-Husain

Reporter:: Alexey Panchenko

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Dates

Created:: 31/Aug/06 05:53

Updated:: 08/Mar/07 00:04

Resolved:: 24/Sep/06 03:52