Uploaded image for project: 'Velocity'
  1. Velocity
  2. VELOCITY-433

Replace parser pool

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5
    • Component/s: Engine
    • Labels:
      None

      Description

      You cannot configure a class that does parser pooling, which makes it hard to balance between the # of instances to pool and the amount of heap space you're committing to velocity.

      This patch refactors the parser pooling logic so that it behaves with a typical pool and parser factory concept. The existing pool implementation class is left untouched and is wrapped by the new default class that implements the new ParserPool interface.

      Behavior and benchmark appears consistent. Tried to format code correctly, but probably missed some spots. One patch file and 2 new java files. Will attach shortly.

        Attachments

        1. ParserPool.java
          1 kB
          Serge Knystautas
        2. ParserPoolImpl.java
          2 kB
          Serge Knystautas
        3. pool-parsers.txt
          7 kB
          Serge Knystautas

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                serge Serge Knystautas
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: