Velocity
  1. Velocity
  2. VELOCITY-411

org.apache.velocity.app.event.implement.EscapeReference needs a guard against NPE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5
    • Component/s: Engine
    • Labels:
      None

      Description

      If reference value passed to EscapeReference.referenceInsert(String reference, Object value) is null,
      then derived clases produce NPE when trying to do toString()

      This condition shall be guarded like this: ( insert it on line 86 - too trivial for a patch )
      if(value == null)
      return value;

        Activity

        Konstantin Pribluda created issue -
        Hide
        Will Glass-Husain added a comment -

        Thanks - Good catch! Patch applied.

        Show
        Will Glass-Husain added a comment - Thanks - Good catch! Patch applied.
        Will Glass-Husain made changes -
        Field Original Value New Value
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Henning Schmiedehausen added a comment -

        Close all resolved issues for Engine 1.5 release.

        Show
        Henning Schmiedehausen added a comment - Close all resolved issues for Engine 1.5 release.
        Henning Schmiedehausen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12331048 ] Default workflow, editable Closed status [ 12551437 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12551437 ] jira [ 12552124 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Konstantin Pribluda
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development