1. Velocity
  2. VELOCITY-403

Enhance Velocity's LogSystem and internal use thereof


    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5
    • Component/s: Engine
    • Labels:


      After several very, very long debates with Geir over commons-logging, i have become largely convinced that it is something we should do with hesitation (i.e. let's talk about it for 2.0, but not before). i've also begun to have some frustrations with commons-logging in both work projects and in VelocityTools.

      regardless of these issues, it is clear to me that Velocity's LogSystem and use of it is in great need of improvement. we need to lower the priority of many messages, eliminate some, and above all, upgrade the system itself to be more useful.

      some specific, unevaluated, off-the-cuff ideas are:
      -make logging a null-op if no logger is found, rather than panic and break
      -detect jdk 1.4+ logging
      -add a trace level
      -add is<Level>Enabled
      -make it possible to grab a LogSystem instance of sorts, so Velocity extensions can use it more sensibly (i'm tired of the hacks we must do in Tools)

      those are just a few ideas, and they might not all even be feasible. still, i'm hoping to take a whack at some of this and hoping that others can help me out. my volunteer time is still rather limited.

      1. docs.logging.patch
        10 kB
        Nathan Bubna
      2. second.logging.patch
        172 kB
        Nathan Bubna
      3. logging.patch
        136 kB
        Nathan Bubna


        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12551936 ] jira [ 12552319 ]
        Mark Thomas made changes -
        Workflow jira [ 12330276 ] Default workflow, editable Closed status [ 12551936 ]
        Henning Schmiedehausen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Nathan Bubna made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Nathan Bubna made changes -
        Attachment docs.logging.patch [ 12314667 ]
        Will Glass-Husain made changes -
        Assignee Nathan Bubna [ nbubna ] Will Glass-Husain [ wglass ]
        Nathan Bubna made changes -
        Attachment second.logging.patch [ 12314628 ]
        Nathan Bubna made changes -
        Assignee Nathan Bubna [ nbubna ]
        Nathan Bubna made changes -
        Field Original Value New Value
        Attachment logging.patch [ 12314616 ]
        Nathan Bubna created issue -


          • Assignee:
            Will Glass-Husain
            Nathan Bubna
          • Votes:
            0 Vote for this issue
            0 Start watching this issue


            • Created: