Velocity
  1. Velocity
  2. VELOCITY-381

Silent Failure of a toString that return null

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.5
    • Component/s: Engine
    • Labels:
      None
    • Environment:
      Operating System: other
      Platform: Other

      Description

      $!method.toString() -
      $!method.getInstance().toString() -
      $!method -
      $!method.getInstance()

      if the toString method returns null,
      this will return ' - - null - null'

      see attached testcase

      1. ASF.LICENSE.NOT.GRANTED--ContextAware.java
        0.3 kB
        Llewellyn Falco
      2. ASF.LICENSE.NOT.GRANTED--StringResourceLoader.java
        2 kB
        Llewellyn Falco
      3. ASF.LICENSE.NOT.GRANTED--VelocityParser.java
        4 kB
        Llewellyn Falco
      4. ASF.LICENSE.NOT.GRANTED--VelocitySilentTest.java
        1 kB
        Llewellyn Falco
      5. patch2.txt
        0.9 kB
        Will Glass-Husain

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12551365 ] jira [ 12552073 ]
        Mark Thomas made changes -
        Workflow jira [ 12325256 ] Default workflow, editable Closed status [ 12551365 ]
        Henning Schmiedehausen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Henning Schmiedehausen added a comment -

        Close all resolved issues for Engine 1.5 release.

        Show
        Henning Schmiedehausen added a comment - Close all resolved issues for Engine 1.5 release.
        Will Glass-Husain made changes -
        Fix Version/s 1.5 [ 12310253 ]
        Assignee Velocity-Dev List [ velocity-dev@jakarta.apache.org ]
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Will Glass-Husain added a comment -

        added test case to "Diabolical.vm". Broke before the patch. Works after the patch. Thanks!

        Show
        Will Glass-Husain added a comment - added test case to "Diabolical.vm". Broke before the patch. Works after the patch. Thanks!
        Will Glass-Husain made changes -
        Attachment patch1.txt [ 12314519 ]
        Will Glass-Husain made changes -
        Attachment patch2.txt [ 12314521 ]
        Hide
        Will Glass-Husain added a comment -

        correct patch by Llwellyn Falco and Dan Powell

        Show
        Will Glass-Husain added a comment - correct patch by Llwellyn Falco and Dan Powell
        Will Glass-Husain made changes -
        Attachment patch1.txt [ 12314519 ]
        Hide
        Will Glass-Husain added a comment -

        Patch by Llwellyn Falco and Dan Powell submitted via dev list.

        Show
        Will Glass-Husain added a comment - Patch by Llwellyn Falco and Dan Powell submitted via dev list.
        Jeff Turner made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 35043 12315251
        Hide
        Llewellyn Falco added a comment -

        Created an attachment (id=15148)
        the test

        the test

        Show
        Llewellyn Falco added a comment - Created an attachment (id=15148) the test the test
        Hide
        Llewellyn Falco added a comment -

        Created an attachment (id=15147)
        needed for test

        needed for test

        Show
        Llewellyn Falco added a comment - Created an attachment (id=15147) needed for test needed for test
        Hide
        Llewellyn Falco added a comment -

        Created an attachment (id=15146)
        needed for test

        needed for test

        Show
        Llewellyn Falco added a comment - Created an attachment (id=15146) needed for test needed for test
        Hide
        Llewellyn Falco added a comment -

        Created an attachment (id=15145)
        class needed for test

        needed for test

        Show
        Llewellyn Falco added a comment - Created an attachment (id=15145) class needed for test needed for test
        Llewellyn Falco created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Llewellyn Falco
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development