1. Velocity
  2. VELOCITY-185

[PATCH] ant test-encoding fails on Windows


    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0-Release
    • Fix Version/s: None
    • Component/s: Engine
    • Labels:
    • Environment:
      Operating System: other
      Platform: PC


      Ant test fails on Windows (specifically ant test-encoding) due to a problem
      matching newlines between the result of parsing "encodingtest2.vm" and the
      expected result "encodingtest2.cmp".

      Apparently, WinCVS translates Unix newline (LF) to the Windows newline (CR LF)
      when checking out the files. But the file "encodingtest2.cmp" already has
      newlines in the windows format CR LF. When it's checked out to a Win machine,
      this turns into CR CR LF. The result file (generated by the Velocity test),
      generates CR LF for newline.

      According to the Java Spec, the unusual case of CR CR LF should be treated as
      a single newline [1], along with CR LF and LF. The Velocity test is smart
      enough to normalize newlines (to make CR LF the same as LF). But does not
      treat CR CR LF as a newline. Thus the compare file doesn't match the result
      file and the test fails.

      Got all that?

      One solution would be to use CygWin CVS, which preserves the Unix newline
      (LF), or check the box in WinCVS "Checkout files with the Unix LF".

      A better solution is to change the routine in Velocity test
      (normalizeNewlines) that normalizes the newlines, to treat the following as
      equivalent newlines LF (unix), CR LF (win), and CR CR LF (win mistranslated).
      The one-line patch is attached,




        Will Glass-Husain created issue -
        Jeff Turner made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 20992 12315055
        Henning Schmiedehausen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12325060 ] Default workflow, editable Closed status [ 12551444 ]
        Mark Thomas made changes -
        Assignee Velocity-Dev List [ ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12551444 ] jira [ 12552372 ]


          • Assignee:
            Will Glass-Husain
          • Votes:
            0 Vote for this issue
            0 Start watching this issue


            • Created: