Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.3-rc1
    • Fix Version/s: 1.6
    • Component/s: Engine
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All

      Description

      currently, it appears that more than two levels get almost unfeasible.
      see also http://sourceforge.net/mailarchive/message.php?msg_id=4015929

      Being able to do multi-line string literals or macro arguments is probably a
      related idea (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17803)

        Activity

        Ralf Hauser created issue -
        Jeff Turner made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 17804 12315019
        Hide
        Will Glass-Husain added a comment -

        Specifically, this suggestion is to allow syntax like

        #abc (#xyz ("argument") )

        ?

        FYI: Multi-line inputs in (upcoming) 1.5 release are now allowed.

        Show
        Will Glass-Husain added a comment - Specifically, this suggestion is to allow syntax like #abc (#xyz ("argument") ) ? FYI: Multi-line inputs in (upcoming) 1.5 release are now allowed.
        Will Glass-Husain made changes -
        Environment Operating System: All
        Platform: All
        Operating System: All
        Platform: All
        Fix Version/s 1.4 [ 12310249 ]
        Bugzilla Id 17804
        Assignee Velocity-Dev List [ velocity-dev@jakarta.apache.org ]
        Description currently, it appears that more than two levels get almost unfeasible.
        see also http://sourceforge.net/mailarchive/message.php?msg_id=4015929

        Being able to do multi-line string literals or macro arguments is probably a
        related idea (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17803)
        currently, it appears that more than two levels get almost unfeasible.
        see also http://sourceforge.net/mailarchive/message.php?msg_id=4015929

        Being able to do multi-line string literals or macro arguments is probably a
        related idea (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17803)
        Hide
        Henning Schmiedehausen added a comment -

        Look into this for 1.5, either postpone or resolve it before releasing 1.5

        Show
        Henning Schmiedehausen added a comment - Look into this for 1.5, either postpone or resolve it before releasing 1.5
        Henning Schmiedehausen made changes -
        Component/s Engine [ 12311337 ]
        Component/s Source [ 12310214 ]
        Fix Version/s 1.5 [ 12310253 ]
        Bugzilla Id 17804
        Hide
        Will Glass-Husain added a comment -

        I like the idea, but there's no patch available and the syntax change is non-trivial.

        Unless you are someone steps up to do this, I suggest postponing.

        Show
        Will Glass-Husain added a comment - I like the idea, but there's no patch available and the syntax change is non-trivial. Unless you are someone steps up to do this, I suggest postponing.
        Hide
        Christoph Reck added a comment -

        The multi-line directives of (upcoming) 1.5 release and the better quote-escaping ("using a doubled "" quote" in the quoted string"), seems to make this request obsolete.

        The following looks akward to me:
        #macro1("foo-#macro2("bar")-baz")
        Can someone tell me in which programming language this would be possible?

        Going with normal "programming" practices, you would unwrap this into:
        #set( $bar = "#macro2('bar')" )
        #macro1("foo-$

        {bar}

        -baz")

        OTOH, this requests seems related to http://www.mail-archive.com/velocity-dev@jakarta.apache.org/msg11751.html which could be more useful than the above akward assembly.

        Show
        Christoph Reck added a comment - The multi-line directives of (upcoming) 1.5 release and the better quote-escaping ("using a doubled "" quote" in the quoted string"), seems to make this request obsolete. The following looks akward to me: #macro1("foo-#macro2("bar")-baz") Can someone tell me in which programming language this would be possible? Going with normal "programming" practices, you would unwrap this into: #set( $bar = "#macro2('bar')" ) #macro1("foo-$ {bar} -baz") OTOH, this requests seems related to http://www.mail-archive.com/velocity-dev@jakarta.apache.org/msg11751.html which could be more useful than the above akward assembly.
        Hide
        Will Glass-Husain added a comment -

        Is the "Macro with Body Content" idea (from the email) in JIRA somewhere? That seems pretty cool.

        Show
        Will Glass-Husain added a comment - Is the "Macro with Body Content" idea (from the email) in JIRA somewhere? That seems pretty cool.
        Hide
        Henning Schmiedehausen added a comment -

        Will,

        any chance to make this work for 1.5? To me it looks like this misses the boat. It looks like a bigger change than I'd like to have for beta2 -> final and we have no patches floating around for it.

        Show
        Henning Schmiedehausen added a comment - Will, any chance to make this work for 1.5? To me it looks like this misses the boat. It looks like a bigger change than I'd like to have for beta2 -> final and we have no patches floating around for it.
        Hide
        Will Glass-Husain added a comment -

        I think we should postpone it. it's a three year old issue with no patch that changes basic syntax. seems an easy call.

        Show
        Will Glass-Husain added a comment - I think we should postpone it. it's a three year old issue with no patch that changes basic syntax. seems an easy call.
        Hide
        Nathan Bubna added a comment -

        Agreed. In fact, i've never felt this one would be a worthwhile effort. Better to work on macros with bodies and not bother with this.

        I'd be in favor of closing this as WON'T FIX, if we open a Macro with Body Content case to supersede it.

        Show
        Nathan Bubna added a comment - Agreed. In fact, i've never felt this one would be a worthwhile effort. Better to work on macros with bodies and not bother with this. I'd be in favor of closing this as WON'T FIX, if we open a Macro with Body Content case to supersede it.
        Hide
        Henning Schmiedehausen added a comment -

        Missed the 1.5 boat.

        Show
        Henning Schmiedehausen added a comment - Missed the 1.5 boat.
        Henning Schmiedehausen made changes -
        Fix Version/s 1.5 [ 12310253 ]
        Fix Version/s 1.6 [ 12310290 ]
        Hide
        Nathan Bubna added a comment -

        This has been superseded by VELOCITY-583.

        Show
        Nathan Bubna added a comment - This has been superseded by VELOCITY-583 .
        Nathan Bubna made changes -
        Resolution Won't Fix [ 2 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Mark Thomas made changes -
        Workflow jira [ 12325024 ] Default workflow, editable Closed status [ 12551911 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12551911 ] jira [ 12552688 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1986d 13h 1m 1 Nathan Bubna 15/Aug/08 03:52

          People

          • Assignee:
            Unassigned
            Reporter:
            Ralf Hauser
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development