[VCL-868] OS.pm::wait_for_no_ping uses computer's hostname, change to use IP address

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.2
• Fix Version/s: 2.5
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 24/Apr/15 15:44
• Updated: 12/Aug/15 17:09
• Resolved: 07/Jul/15 17:50

Description

OS.pm::wait_for_no_ping calls utils.pm::_pingnode and passes it the result of $self->data->get_computer_node_name. This fails if the computer's hostname does not resolve to its private IP address – if it isn't in /etc/hosts.

This causes problems such as during image capture of Windows images:

2015-04-24 11:15:44|5733|2688796|2790931|image|Windows.pm:reboot|3654|executed reboot command on vi1-216
2015-04-24 11:15:44|5733|2688796|2790931|image|Module.pm:code_loop_timeout|1420|waiting for vi1-216 to NOT respond to ping, code returned true
2015-04-24 11:15:49|5733|2688796|2790931|image|Module.pm:code_loop_timeout|1429|attempt 1: waiting for vi1-216 to respond to ping (0/300 elapsed/remaining seconds), sleeping for 15 seconds
...
015-04-24 11:20:49|5733|2688796|2790931|image|Module.pm:code_loop_timeout|1429|attempt 21: waiting for vi1-216 to respond to ping (300/0 elapsed/remaining seconds), sleeping for 0 seconds
2015-04-24 11:20:49|5733|2688796|2790931|image|Module.pm:code_loop_timeout|1443|waiting for vi1-216 to respond to ping, code did not return true after waiting 300 seconds
|5733|2688796|2790931|image|OS.pm:wait_for_reboot|714| ---- WARNING ----
|5733|2688796|2790931|image|OS.pm:wait_for_reboot|714| 2015-04-24 11:20:49|5733|2688796|2790931|image|OS.pm:wait_for_reboot|714|vi1-216 never responded to ping
|5733|2688796|2790931|image|OS.pm:wait_for_reboot|714| ( 0) OS.pm, wait_for_reboot (line: 714)
|5733|2688796|2790931|image|OS.pm:wait_for_reboot|714| (-1) Windows.pm, reboot (line: 3691)
|5733|2688796|2790931|image|OS.pm:wait_for_reboot|714| (-2) Windows.pm, disable_pagefile (line: 2341)
|5733|2688796|2790931|image|OS.pm:wait_for_reboot|714| (-3) Windows.pm, pre_capture (line: 551)
|5733|2688796|2790931|image|OS.pm:wait_for_reboot|714| (-4) Version_6.pm, pre_capture (line: 171)
|5733|2688796|2790931|image|OS.pm:wait_for_reboot|714| (-5) 7.pm, pre_capture (line: 100)
2015-04-24 11:20:49|5733|2688796|2790931|image|OS.pm:wait_for_reboot|673|vi1-216 reboot failed to complete on previous attempt, attempting hard power reset

The code should be changed to use the return value of utils.pm::determine_remote_connection_target.