[VCL-841] VMware.pm::configure_vmhost_dedicated_ssh_key may fail

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4
• Fix Version/s: 2.4.1
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 19/Mar/15 19:51
• Updated: 19/Mar/15 19:54
• Resolved: 19/Mar/15 19:54

Description

The configure_vmhost_dedicated_ssh_key in VMware.pm should not be called unless VMware ESXi 4.x is used. It allows the SSH authorized_keys to persist across reboots.

In some cases, it generates warnings in vcld.log:

|847|28|56|timeout|OS.pm:create_text_file|2210| ---- WARNING ----
|847|28|56|timeout|OS.pm:create_text_file|2210| 2015-03-19 15:38:17|847|28|56|timeout|OS.pm:create_text_file|2210|failed to execute command to create a file on blade1e1-10:
|847|28|56|timeout|OS.pm:create_text_file|2210| command: 'echo -e "\x62\x6f\x6f\x74\x73\x74\x61\x74\x65\x3d\x30\xa\x6b\x65\x72\x6e\x65\x6c
...
\x31\x38\xa\x75\x70\x64\x61\x74\x65\x64\x3d\x31\xa" > /bootbank/boot.cfg', exit status: 1, output:
|847|28|56|timeout|OS.pm:create_text_file|2210| /bin/sh: File too large
|847|28|56|timeout|OS.pm:create_text_file|2210| ( 0) OS.pm, create_text_file (line: 2210)
|847|28|56|timeout|OS.pm:create_text_file|2210| (-1) VMware.pm, configure_vmhost_dedicated_ssh_key (line: 7591)
|847|28|56|timeout|OS.pm:create_text_file|2210| (-2) VMware.pm, initialize (line: 381)
|847|28|56|timeout|OS.pm:create_text_file|2210| (-3) Module.pm, new (line: 224)
|847|28|56|timeout|OS.pm:create_text_file|2210| (-4) Module.pm, create_provisioning_object (line: 727)
|847|28|56|timeout|OS.pm:create_text_file|2210| (-5) State.pm, initialize (line: 205)

This warning was generated from an ESXi 5.5 host. I'm not sure it is a problems for 4.x. Either way, it should be disabled for 5.x hosts. I don't think it's worth putting too much effort into since it is no longer necessary for modern hosts. No harm is done when this subroutine fails. It is only called if the state is timeout.