[VCL-774] _get_file_info is unnecessarily slow for vSphere provisioning

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.2
• Fix Version/s: 2.4
• Component/s: vcld (backend)
• Labels: performance

Environment

VMware vSphere

• Assignee: Aaron Coburn
• Reporter: Aaron Coburn
• Created: 22/Aug/14 13:36
• Updated: 23/Dec/14 14:20
• Resolved: 22/Aug/14 14:08

Description

The vSphere_SDK.pm:_get_file_info subroutine is unnecessarily slow on systems with large numbers of virtual machines (especially vCenter clusters).

This is due to an overly comprehensive query definition in the HostDatastoreBrowserSearchSpec object.

The query definition includes the following (around line 2483):

VmDiskFileQuery->new(...),
FileQuery->new(),
FloppyImageFileQuery->new(),
FolderFileQuery->new(),
IsoImageFileQuery->new(),
VmConfigFileQuery->new(),
VmLogFileQuery->new(),
VmNvramFileQuery->new(),
VmSnapshotFileQuery->new()

But in truth only the following are needed in the query:

VmDiskFileQuery->new(...),
FileQuery->new(),
FolderFileQuery->new(),

In my system, this drops the execution time of _get_file_info() from ~ 3.5 minutes to ~ 5 seconds.

Issue Links

• is duplicated by: VCL-686 vSphere_SDK.pm::_get_file_info slow