[VCL-755] Add 'if defined' checks for all get_management_node_info calls

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.2
• Fix Version/s: 2.4
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 24/Mar/14 13:27
• Updated: 15/Dec/14 21:46
• Resolved: 15/Dec/14 21:46

Description

There are calls to get_management_node_info in utils.pm, DataStructure.pm, and healthcheck.pm which do not check if a defined value is returned such as:

$identity_paths = get_management_node_info()->{keys};

There are cases where get_management_node_info will fail and return null such as if a database connection cannot be obtained. When this happens and the caller doesn't check for a defined value, the following unhandled error is generated:

Can't use an undefined value as a HASH reference at /usr/local/vcl/bin/../lib/VCL/utils.pm line 4017.

Every line containing get_management_node_info()-> should be changed to first retrieve the info, then check it, then access the hash reference value.