[VCL-743] run_ssh_command fails if SSH key permissions are incorrect

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.4
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 02/Jan/14 18:55
• Updated: 22/Dec/14 21:58
• Resolved: 22/Dec/14 21:58

Description

run_ssh_command may fail to correctly parse output if the SSH command attempts to use an identity key with incorrect permissions. This occurs even though the command succeeded by using another key. If the permissions are incorrect on the private key, the following will be displayed:

@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@         WARNING: UNPROTECTED PRIVATE KEY FILE!          @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
Permissions 0644 for '/etc/vcl/bad.key' are too open.
It is recommended that your private key files are NOT accessible by others.
This private key will be ignored.
bad permissions: ignore key: /etc/vcl/bad.key
<correct output starts here>

The run_ssh_command subroutine in utils.pm needs to be extended to detect this and strip away the warning output.