[VCL-679] utils.pm:get_computer_info using image.name to retrieve imagerevision info

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3
• Fix Version/s: 2.4
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 27/Feb/13 16:45
• Updated: 20/Nov/14 14:44
• Resolved: 06/Mar/13 20:48

Description

get_computer_info is retrieving computer.nextimageid, using this to retrieve the image info, and then using the image.name value to retrieve the imagerevision info. It's possible that an image.name value does not have a corresponding entry in imagerevision.imagename. The following will appear in vcld.log if this is the case:

31709	2104580:2193018	inuse	---- WARNING ----
31709	2104580:2193018	inuse	2013-02-27 04:13:19	31709	2104580:2193018	inuse	utils.pm:get_imagerevision_info(4253)	imagerevision 'vmwarewinxp-SAS93EGEMinerTextMiner3198-v3' was not found in the database, 0 rows were returned from database select statement:
31709	2104580:2193018	inuse	SELECT
31709	2104580:2193018	inuse	imagerevision.*
31709	2104580:2193018	inuse	FROM
31709	2104580:2193018	inuse	imagerevision
31709	2104580:2193018	inuse	WHERE
31709	2104580:2193018	inuse	imagerevision.imagename = 'vmwarewinxp-SAS93EGEMinerTextMiner3198-v3'
31709	2104580:2193018	inuse	( 0) utils.pm, get_imagerevision_info (line: 4253)
31709	2104580:2193018	inuse	(-1) utils.pm, get_computer_info (line: 7740)
31709	2104580:2193018	inuse	(-2) utils.pm, get_request_info (line: 3829)
31709	2104580:2193018	inuse	(-3) vcld, main (line: 286)

image.name should not be used anywhere and the column should probably be removed from the database altogether. imagerevision.imagename is authoritative.