[VCL-671] VMware may delete VM assigned to another reservation when reclaiming disk space on the host

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.1
• Fix Version/s: 2.3.2
• Component/s: vcld (backend)

Environment

Only affects hosts where the vmpath is tight on disk space.

• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 30/Jan/13 15:43
• Updated: 30/Jan/13 15:51
• Resolved: 30/Jan/13 15:51

Description

There is a logic bug in VMware.pm::reclaim_vmhost_disk_space. It retrieves the other VMs currently loaded on the host and checks if the VM is assigned to another reservation. If so, the VM should not be deleted. If not assigned to any other reservations, the other VM may be a candidate for deletion if space needs to be reclaimed on the host in order to load the VM for the current reservation.

A hash reference is returned to reclaim_vmhost_disk_space by utils.pm::get_request_by_computerid. The return value is checked:
my $computer_requests = get_request_by_computerid($check_computer_id);
if (!keys(%$computer_requests)) {

1. Not deletable
   }
   else {
2. Deletable
   }

This logic is backwards.