[VCL-624] getUserlistID should be passed a user's full login string, not just a unityid

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3
• Fix Version/s: 2.3.1, 2.4
• Component/s: web gui (frontend)
• Assignee: Aaron Coburn
• Reporter: Aaron Coburn
• Created: 07/Sep/12 16:53
• Updated: 07/Sep/12 17:56
• Resolved: 07/Sep/12 17:56

Description

The utils.php:getUserlistID() function expects a loginid value, but there are places in the web code where it is being passed a unityid (i.e. the loginid stripped of an AFFILIATION) instead. There are also some naming conventions, such as in utils.php:addUserGroupMember() where the variables suggest the use of a $unityid, but in reality, these are $loginid values.

The only place where this is really an issue is in updateRequest() – and then only if the system is using a custom set of findAffilFuncs that don't set a default affiliation. And there, the call to getUserlistID appears to be entirely superfluous.