[VCL-334] numeric userids are not handled correctly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.2
• Component/s: web gui (frontend)
• Assignee: Unassigned
• Reporter: Josh Thompson
• Created: 20/May/10 19:58
• Updated: 05/Aug/10 19:21
• Resolved: 05/Aug/10 19:21

Description

This is what I sent someone about how to fix the problem:

modify getUserInfo in utils.php (starts on line 2797) to accept an additional argument:

replace

function getUserInfo($id) {

with

function getUserInfo($id, $numeric=0) {

modify the 1st "if" statement in getUserInfo

replace

if(! is_numeric($id))

with

if(! $numeric)

modify the 2nd "if" statement in getUserInfo

replace

if(is_numeric($id))

with

if($numeric)

modify the last "if" statement in getUserInfo

replace

if(is_numeric($id))

with

if($numeric)

Now, we need to modify the functions that call getUserInfo with a numeric argument. While you're already in utils.php, go to line 1673. You should be in addOwnedResourceGroups.

replace

$user = getUserInfo($userid);

with

$user = getUserInfo($userid, 1);

Modify checkUserHasPriv in privileges.php (should be line 2716):

replace

$_user = getUserInfo($uid);

with

$_user = getUserInfo($uid, 1);

Modify viewRequestInfo in requests.php (should be line 2243)

replace

$userinfo = getUserInfo($request["userid"]);

with

$userinfo = getUserInfo($request["userid"], 1);

Modify confirmDeleteRequest in requests.php (should be line 3130)

replace

$userinfo = getUserInfo($request["userid"]);

with

$userinfo = getUserInfo($request["userid"], 1);

Modify submitUserPrefs in userpreferences.php (should be line 484)

replace

$user = getUserInfo($user["id"]);

with

$user = getUserInfo($user["id"], 1);