[VCL-1061] Unnecessary warnings in vcld.log for Ubuntu 16 images when checking services

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.2
• Fix Version/s: 2.5
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 19/Jul/17 18:15
• Updated: 20/Jul/17 17:54
• Resolved: 20/Jul/17 17:54

Description

Ubuntu 16+ uses systemd instead of Upstart but the initctl command may still exist. The Upstart.pm checks if the initctl command exists in order to determine if it should be used.

The module attempts to execute initctl list when retrieving service names. With Ubuntu 16, the following is displayed:

initctl: Unable to connect to Upstart: Failed to connect to socket /com/ubuntu/upstart: Connection refused

As a result, the following appears in vcld.log:

Upstart.pm:_get_service_info|189| ---- WARNING ----
Upstart.pm:_get_service_info|189| 2017-07-19 14:07:04Upstart.pm:_get_service_info|189|failed to retrieve list of all services on arkvmm165 using the initctl command, exit status: 1, command:
Upstart.pm:_get_service_info|189| initctl list
Upstart.pm:_get_service_info|189| output:
Upstart.pm:_get_service_info|189| initctl: Unable to connect to Upstart: Failed to connect to socket /com/ubuntu/upstart: Connection refused
Upstart.pm:_get_service_info|189| ( 0) Upstart.pm, _get_service_info (line: 189)
Upstart.pm:_get_service_info|189| (-1) Upstart.pm, get_service_names (line: 133)
Upstart.pm:_get_service_info|189| (-2) Linux.pm, service_exists (line: 3702)
Upstart.pm:_get_service_info|189| (-3) test.pm, process (line: 81)
Upstart.pm:_get_service_info|189| (-4) vcld, make_new_child (line: 601)
Upstart.pm:_get_service_info|189| (-5) vcld, main (line: 353)

The ultimate functionality is fine since the systemd.pm module then checks if it can retrieve the service names. This succeeds. However, unnecessary warnings appear in vcld.log.