[VCL-1055] 'Use of uninitialized value in lc' warning may be generated from a few subroutines

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 23/Jun/17 18:10
• Updated: 21/Jul/17 17:53
• Resolved: 23/Jun/17 18:14

Description

There are a few subroutines calling:

my $network_type = lc(shift()) || 'public';

If an argument isn't specified, the following warning is generated:

|8075|16|16|reinstall|vcld:warning_handler|646| ---- WARNING ----
|8075|16|16|reinstall|vcld:warning_handler|646| 2017-06-23 12:50:10|8075|16|16|reinstall|vcld:warning_handler|646|Use of uninitialized value in lc at /usr/local/vcl-2.5-RC1/bin/../lib/VCL/Module/OS.pm line 2641.
|8075|16|16|reinstall|vcld:warning_handler|646| ( 0) vcld, warning_handler (line: 646)
|8075|16|16|reinstall|vcld:warning_handler|646| (-1) OS.pm, get_default_gateway (line: 2641)
|8075|16|16|reinstall|vcld:warning_handler|646| (-2) OS.pm, update_public_ip_address (line: 1515)
|8075|16|16|reinstall|vcld:warning_handler|646| (-3) OS.pm, reserve (line: 221)
|8075|16|16|reinstall|vcld:warning_handler|646| (-4) Windows.pm, reserve (line: 1045)
|8075|16|16|reinstall|vcld:warning_handler|646| (-5) new.pm, reserve_computer (line: 875)
|8075|16|16|reinstall|vcld:warning_handler|646| (-6) new.pm, process (line: 381)
|8075|16|16|reinstall|vcld:warning_handler|646| (-7) vcld, make_new_child (line: 601)
|8075|16|16|reinstall|vcld:warning_handler|646| (-8) vcld, main (line: 353)