[VCL-1052] Prevent captures from failing if VM disk mode is 'dedicated' and the repository is not configured

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Implemented
• Fix Version/s: 2.5
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 30/May/17 18:36
• Updated: 30/May/17 18:40
• Resolved: 30/May/17 18:40

Description

VMware.pm's capture subroutine currently aborts if vmprofile.vmdisk is set to dedicated and the repository path is not configured. This was done to prevent reclaim_vmhost_disk_space from deleting image directories that may be shared with other hosts. This is a common base image creation problem since it hasn't been well-documented. The vcld.log error is:

VMware.pm:capture|660| ---- CRITICAL ---- 
VMware.pm:capture|660| 2017-05-24 08:22:23VMware.pm:capture|660|disk type is set to 'dedicated' but the repository path is NOT configured for VM profile 'VMware ESXi - local storage', this configuration is not allowed because it may result in vmdk directories being deleted without a backup copy saved in the image repository
VMware.pm:capture|660| ( 0) VMware.pm, capture (line: 660)
VMware.pm:capture|660| (-1) image.pm, process (line: 179)
VMware.pm:capture|660| (-2) vcld, make_new_child (line: 587)
VMware.pm:capture|660| (-3) vcld, main (line: 348)

It would be better to add logic to reclaim_vmhost_disk_space to prevent possible deletion and allow captures to proceed.