[VCL-1032] VIM_SSH.pm::get_config_option_info very slow when using run_ssh_command

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.2
• Fix Version/s: 2.5
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 30/Mar/17 21:53
• Updated: 30/Mar/17 22:35
• Resolved: 30/Mar/17 22:35

Description

VIM_SSH.pm::get_config_option_info causes vim-cmd solo/querycfgopt to be executed on an ESXi host. The output is rather complex.

When utils.pm::run_ssh_command is used to execute the command (rather than OS.pm::execute_new), there is a 1-2 minute or more pause as the following lines are executed:

$ssh_output =~ s/.*ssh-askpass:[^\n]*//igs;
$ssh_output =~ s/.*bad permissions:[^\n]*//igs;

The problem is due to the /s parameter. Removing it speeds processing these lines up.