Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
-
None
-
Operating System: other
Platform: PC
-
37315
Description
The use of Element.getAttributeNode("name") is not supported by IE prior to
version 6. This error was reportedly fixed in COM-2145 but the resolution to
still uses getAttributeNode("name").
document.getAttributeNode() is present in:
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateFloatRange.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateShort.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateMinLength.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateDate.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateEmail.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateByte.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateIntRange.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateMask.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateCreditCard.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateInteger.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateMaxLength.js
./jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateFloat.js
This is issue has also previously been raised in COM-1622, with an appropriate
patch being supplied.
Firstly, there is no reference to getAttributeNode() in any of the scripts you
indicate since the fix/patch applied for Firstly, there is no reference to getAttributeNode() in any of the scripts you
indicate since the fix/patch applied for Bug 35127 refactored the code to get
the form name into a separate utility method - retrieveFormName() - which is
located in validateUtilities.js
Having said that - that script does still use the getAttributeNode() function,
but IMO its now less of an issue - since anyone wanting IE 5.5 support can
simply provide their own implementation of that method and configure validator
to use it.
Personally I haven't been involved in that change and don't have a copy of IE
5.5 to test on. If you could supply a patch which resolves this in IE 5.5 then
I will apply it. It needs to be soon though, if you want it included in
Validator 1.2.0 - I just finished rolling "release candidate 2" when you posted
this:
http://www.mail-archive.com/commons-dev%40jakarta.apache.org/msg68919.html refactored the code to get
the form name into a separate utility method - retrieveFormName() - which is
located in validateUtilities.js
Having said that - that script does still use the getAttributeNode() function,
but IMO its now less of an issue - since anyone wanting IE 5.5 support can
simply provide their own implementation of that method and configure validator
to use it.
Personally I haven't been involved in that change and don't have a copy of IE
5.5 to test on. If you could supply a patch which resolves this in IE 5.5 then
I will apply it. It needs to be soon though, if you want it included in
Validator 1.2.0 - I just finished rolling "release candidate 2" when you posted
this:
http://www.mail-archive.com/commons-dev%40jakarta.apache.org/msg68919.html