[UNOMI-492] Handle NullPointerException with corrupted rules

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: unomi-1.5.6
• Fix Version/s: unomi-1.5.7
• Component/s: unomi(-core)
• Assignee: Unassigned
• Reporter: Serge Huber
• Created: 14/Jun/21 13:09
• Updated: 23/Jul/21 10:16
• Resolved: 01/Jul/21 07:20

Description

We've had some reports of NPEs when rules get corrupted and instead of having a list of actions actually have a NULL reference.

This causes the following error in the logs:

2021-06-10T09:17:47,406 | ERROR | pool-15-thread-1 | RulesServiceImpl                 | 178 - org.apache.unomi.services - 1.5.6 |  Error loading rules from persistence back-end 
java.lang.NullPointerException: null
        at org.apache.unomi.services.impl.ParserHelper.resolveActionTypes(ParserHelper.java:101) ~[!/:?]
        at org.apache.unomi.services.impl.rules.RulesServiceImpl.getAllRules(RulesServiceImpl.java:252) ~[!/:?]
        at org.apache.unomi.services.impl.rules.RulesServiceImpl.access$100(RulesServiceImpl.java:45) ~[!/:?]
        at org.apache.unomi.services.impl.rules.RulesServiceImpl$1.run(RulesServiceImpl.java:398) [!/:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_292]
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [?:1.8.0_292]