Uploaded image for project: 'UIMA'
  1. UIMA
  2. UIMA-4158

Make THROW_EXCEPTION_FS_UPDATES_CORRUPTS and friends public

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0SDK
    • Fix Version/s: 2.7.0SDK
    • Component/s: Core Java Framework
    • Labels:
      None

      Description

      We have constants defined in CasImpl, but they are not public THROW_EXCEPTION_FS_UPDATES_CORRUPTS. I would like to set such properties programmatically from unit tests and having these constants public would be very convenient for this. E.g. I would immediately notice when such functionality is changed/removed, e.g. as has happened in recent changes related to UIMA-4135.

      Mind that CASImpl.CHK_FS_UPDATES_CORRUPTS had been public while it still had existed.

        Activity

        Hide
        schor Marshall Schor added a comment -

        This was an oversight... I'm wondering if the static constants should be moved to the CAS Interface? WDYT?

        Show
        schor Marshall Schor added a comment - This was an oversight... I'm wondering if the static constants should be moved to the CAS Interface? WDYT?
        Hide
        rec Richard Eckart de Castilho added a comment -

        I'm not sure. If there are other implementations of the CAS interface, they may not be controllable via these properties. Maybe they are more of an implementation detail than part of the official API.

        Show
        rec Richard Eckart de Castilho added a comment - I'm not sure. If there are other implementations of the CAS interface, they may not be controllable via these properties. Maybe they are more of an implementation detail than part of the official API.
        Hide
        schor Marshall Schor added a comment -

        good point, thanks! I'll keep these as CASImpl things... but public, as you suggest.

        Show
        schor Marshall Schor added a comment - good point, thanks! I'll keep these as CASImpl things... but public, as you suggest.
        Hide
        schor Marshall Schor added a comment -

        kept in the impl classes

        Show
        schor Marshall Schor added a comment - kept in the impl classes

          People

          • Assignee:
            schor Marshall Schor
            Reporter:
            rec Richard Eckart de Castilho
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development