Uploaded image for project: 'UIMA'
  1. UIMA
  2. UIMA-3869

Better maven-plugin-plugin configuration

    Details

      Description

      Better workaround to fix missing descriptors failure:

      http://jira.codehaus.org/browse/MPLUGIN-267

              <groupId>org.apache.maven.plugins</groupId>
              <artifactId>maven-plugin-plugin</artifactId>
              <version>3.3</version>
              <executions>
                <execution>
                  <id>default-descriptor</id>
                  <phase>process-classes</phase>
                </execution>
      

        Issue Links

          Activity

          Hide
          rec Richard Eckart de Castilho added a comment -

          Actually, running the helpmojo in process-classes does not work as intended. It generates the HelpMojo.java file but never compiles it.

          For the helpmojo, we still need to ignore the presence of the descriptor file, but this workaround can be removed when we upgrade to maven-plugin-plugin:3.4: https://jira.codehaus.org/browse/MPLUGIN-238

          Show
          rec Richard Eckart de Castilho added a comment - Actually, running the helpmojo in process-classes does not work as intended. It generates the HelpMojo.java file but never compiles it. For the helpmojo, we still need to ignore the presence of the descriptor file, but this workaround can be removed when we upgrade to maven-plugin-plugin:3.4: https://jira.codehaus.org/browse/MPLUGIN-238
          Hide
          rec Richard Eckart de Castilho added a comment - - edited

          Since this change is removing the option to ignore whether descriptors have been generated, it also requires that the phase of the help-mojo is set to "process-classes":

          <execution>
            <id>help-goal</id>
            <phase>process-classes</phase>
            <goals><goal>helpmojo</goal></goals>
          </execution>
          

          Since we do not configure the helpmojo in the uima-parent-pom, this needs to be fixed in the individual Maven plugin modules.

          Two options:

          1. really fix it in the modules
          2. remove the help-mojo config in the modules and add it in the parent-pom

          I'd opt for the second option. Opinions?

          Show
          rec Richard Eckart de Castilho added a comment - - edited Since this change is removing the option to ignore whether descriptors have been generated, it also requires that the phase of the help-mojo is set to "process-classes": <execution> <id>help-goal</id> <phase>process-classes</phase> <goals><goal>helpmojo</goal></goals> </execution> Since we do not configure the helpmojo in the uima-parent-pom, this needs to be fixed in the individual Maven plugin modules. Two options: really fix it in the modules remove the help-mojo config in the modules and add it in the parent-pom I'd opt for the second option. Opinions?

            People

            • Assignee:
              rec Richard Eckart de Castilho
              Reporter:
              rec Richard Eckart de Castilho
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development