Details
-
Task
-
Status: Closed
-
Critical
-
Resolution: Fixed
-
None
-
None
Description
Jean Anderson wrote on general@incubator.apache.org:
I reviewed the uimaj-2.1.0-incubating-src.tar.gz distribution. The
signature verified fine. The incubator disclaimer in the DISCLAIMER and
README files, which looks good to me.
Below are four issues I spotted.
(1) Source headers in generated output
info from original post:
> We've run the RAT utility and have posted the reports, along with our
> own comments, here:
> http://people.apache.org/~alally/uima-2.1.0-incubating/RAT/RAT-src.txt
> http://people.apache.org/~alally/uima-2.1.0-incubating/RAT/RAT-bin.txt
>
> The original unedited RAT reports are also posted:
> http://people.apache.org/~alally/uima-2.1.0-incubating/RAT/RAT-src-full.txt
> http://people.apache.org/~alally/uima-2.1.0-incubating/RAT/RAT-bin-full.txt
Thanks for posting your RAT output, especially since you noted "the
current version of RAT crashes on the UIMA source distrib".
Regarding not including the ASF header in generated output, although it
isn't required it's still a good idea to include it where feasible so
end users aren't confused about usage [1].
In my opinion it isn't a show stopper for this release, but if I were
you, I'd go ahead and include the header when in doubt and if it's
reasonable to do so.
Incidently, the src-headers page [2] mentions a handy tool in the
committers repo [3] that will actually slap those headers on for you in
a comment for various file types.
(2) Old headers
When I ran insert_license.pl [3] in "practice" mode, it spotted these
files that have the old-style copyright, and they must be replaced with
the current header [2]:
uimaj-2.1.0-incubating/uima-docbooks/CatalogManager.properties
uimaj-2.1.0-incubating/uima-docbooks/project.properties
uimaj-2.1.0-incubating/uima-docbooks/MANIFEST
uimaj-2.1.0-incubating/uima-docbooks/xml-catalog.xml
uimaj-2.1.0-incubating/uima-docbooks/src/css/stylesheet.css
uimaj-2.1.0-incubating/uima-docbooks/src/styles/html.xsl
uimaj-2.1.0-incubating/uima-docbooks/src/styles/pdf.xsl
uimaj-2.1.0-incubating/uima-docbooks/src/styles/common_custom.xsl
uimaj-2.1.0-incubating/uima-docbooks/src/styles/htmlsingle.xsl
uimaj-2.1.0-incubating/uima-docbooks/src/styles/pdf/titlepage.xml
uimaj-2.1.0-incubating/uima-docbooks/src/styles/pdf/custom.xsl
uimaj-2.1.0-incubating/uima-docbooks/src/styles/html/titlepage.xml
uimaj-2.1.0-incubating/uima-docbooks/src/styles/html/custom.xsl
insert_license.pl [3] outputs a line like this for these files with the
old header:
uimaj-2.1.0-incubating/uima-docbooks/src/styles/html.xsl,
extension=.xsl, fileType=xml, Found existing license (licenseType=AL-20)
so skipping, WARN: old AL-20 copyright notice
(3) NOTICE file
Wasn't UIMA started with an initial code contribution? If so, I would
expect its NOTICE file to include some sort of attribution; see:
http://www.apache.org/legal/src-headers.html#notice
http://www.apache.org/licenses/example-NOTICE.txt
(4) UIMA Podling status at http://incubator.apache.org/projects/uima.html
The "copyright" and "verify distribution rights" work items haven't been
checked off – that suggests that the ip clearance hasn't quite yet been
completed yet. Or maybe it has and the status just needs to be updated
to reflect reality.
So, issues 2-4 must be fixed.